Skip to content

fix: address provenance review findings for OpenHands/extensions #547 - #2

Closed
enyst wants to merge 2 commits into
review/pr-547-llm-provenancefrom
fix/pr-547-provenance-review-20260910
Closed

fix: address provenance review findings for OpenHands/extensions #547#2
enyst wants to merge 2 commits into
review/pr-547-llm-provenancefrom
fix/pr-547-provenance-review-20260910

Conversation

@enyst

@enyst enyst commented Sep 10, 2026

Copy link
Copy Markdown
Owner
  • A human has tested these changes.

I am an AI agent acting on behalf of Engel.

Why

Follow-up to OpenHands#547 at 7a0dba57a6454c4163f71b8e3711405238fb6b84, addressing its previous review and the linked-provider credential finding.

Summary

  • On a missing selected profile (404), use the already-fetched default LLM and label it default with its actual model; keep authentication, server, malformed-profile, and unresolved-provider errors explicit.
  • Verify or repair the successful GitHub review's provenance footer before marking completion, matching the authenticated author, commit, submitted state, and conversation start time; retry failed publication instead of silently closing it.
  • Apply consistent footer replacement to Slack, document the persisted provenance, add runtime regressions, and regenerate the reviewer bundle as 1.0.2 with matching catalog fixtures.

Issue Number

Supports OpenHands#548 and OpenHands/automation#430.

How to Test

uv run pytest tests skills/github-pr-reviewer/tests -q
uv run pytest tests/test_automation_llm_provenance.py tests/test_slack_channel_monitor.py skills/github-pr-reviewer/tests/test_main.py -q
npm run build:automations
npm run build:skills
uv run python scripts/sync_extensions.py --check
uv run python -m py_compile skills/github-pr-reviewer/scripts/main.py skills/slack-channel-monitor/scripts/main.py
git diff --check

Full suite: 886 passed, 24 skipped; after the final fallback-label adjustment, 89 focused tests passed.
The regressions exercise concrete conversation request bodies, missing/failed profile reads, successful-review footer repair, unrelated reviews, and publication retries.
Generated reviewer bundle verified byte-for-byte against its source.
Repository sync passes with the existing non-blocking coverage warning for issue-duplicate-checker; the generic Codex skill validator does not support this repository's existing triggers frontmatter.

Notes

Runtime dependency: enyst/agent-sdk#28 must be applied upstream and deployed to Agent Server for provider-linked profiles to run correctly.
That fix resolves provider credentials on plaintext profile reads without activating a profile or changing global settings; its 106 API tests and two live-server checks pass.
This extension change fails clearly on older servers that return unresolved credentials.

enyst and others added 2 commits September 10, 2026 07:31
Address profile fallback and successful-review footer findings from OpenHands#547.
Fail clearly if linked credentials need the accompanying Agent Server fix.

Co-authored-by: openhands <openhands@all-hands.dev>
The active profile pointer can drift from the concrete default LLM settings.
Label 404 fallback as default instead of claiming the named profile was read.

Co-authored-by: openhands <openhands@all-hands.dev>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the type: fix A bug fix label Sep 10, 2026
@enyst

enyst commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Relocated upstream: these two commits are now applied directly on the OpenHands#547 branch (openhands/show-llm-provenance), so OpenHands#547 carries them. Closing this fork mirror. — smolpaws for Engel 🐾

@enyst enyst closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant