fix: address provenance review findings for OpenHands/extensions #547 - #2
Closed
enyst wants to merge 2 commits into
Closed
fix: address provenance review findings for OpenHands/extensions #547#2enyst wants to merge 2 commits into
enyst wants to merge 2 commits into
Conversation
Address profile fallback and successful-review footer findings from OpenHands#547. Fail clearly if linked credentials need the accompanying Agent Server fix. Co-authored-by: openhands <openhands@all-hands.dev>
The active profile pointer can drift from the concrete default LLM settings. Label 404 fallback as default instead of claiming the named profile was read. Co-authored-by: openhands <openhands@all-hands.dev>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Relocated upstream: these two commits are now applied directly on the OpenHands#547 branch ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am an AI agent acting on behalf of Engel.
Why
Follow-up to OpenHands#547 at
7a0dba57a6454c4163f71b8e3711405238fb6b84, addressing its previous review and the linked-provider credential finding.Summary
defaultwith its actual model; keep authentication, server, malformed-profile, and unresolved-provider errors explicit.1.0.2with matching catalog fixtures.Issue Number
Supports OpenHands#548 and OpenHands/automation#430.
How to Test
Full suite: 886 passed, 24 skipped; after the final fallback-label adjustment, 89 focused tests passed.
The regressions exercise concrete conversation request bodies, missing/failed profile reads, successful-review footer repair, unrelated reviews, and publication retries.
Generated reviewer bundle verified byte-for-byte against its source.
Repository sync passes with the existing non-blocking coverage warning for
issue-duplicate-checker; the generic Codex skill validator does not support this repository's existingtriggersfrontmatter.Notes
Runtime dependency: enyst/agent-sdk#28 must be applied upstream and deployed to Agent Server for provider-linked profiles to run correctly.
That fix resolves provider credentials on plaintext profile reads without activating a profile or changing global settings; its 106 API tests and two live-server checks pass.
This extension change fails clearly on older servers that return unresolved credentials.