Add RTL text plugin support for Arabic/Hebrew languages#5
Open
yharby wants to merge 1 commit into
Open
Conversation
Initialize maplibregl.setRTLTextPlugin() in both bundles: - ipywidget.js (for Jupyter/Marimo via anywidget) - pymaplibregl.js (for Shiny and standalone HTML) Changes: - Import maplibre-gl in pymaplibregl.js and expose globally - Bundle RTL plugin source for OFFLINE usage (no CDN dependency) - Create blob URL from bundled plugin source - Safe initialization with error handling The RTL plugin (~150KB) is now bundled directly, enabling: - Offline usage without internet connection - No external CDN dependencies - Consistent behavior across all environments Closes eoda-dev#4 Related: eoda-dev/py-maplibregl#157, eoda-dev/py-maplibregl#159
085de3e to
29741df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initialize
maplibregl.setRTLTextPlugin()in both JavaScript bundles to enable proper rendering of right-to-left languages (Arabic, Hebrew, etc.).Changes
Source Files
src/pymaplibregl.js:maplibre-glmodulemaplibreglglobally for compatibilitysrc/ipywidget.js:Built Bundles
py-bindings/pymaplibre.js- Rebuilt with RTL supportpy-bindings/pymaplibre.ipywidget.js- Rebuilt with RTL supportFeatures
unpkg.comfor the plugin, no bundling neededCode Added
Related
Test Plan