Skip to content

Add text, title, target to link #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Add text, title, target to link #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d837c0f
Add text, title, target to link
exacs Nov 10, 2025
b6babd6
Add nullability
exacs Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/optimizely-cms-sdk/src/graph/__test__/createQuery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('createFragment() simple cases', () => {
"fragment ContentUrl on ContentUrl { type default hierarchical internal graph base }",
"fragment IContentMetadata on IContentMetadata { key locale fallbackForLocale version displayName url {...ContentUrl} types published status created lastModified sortOrder variation ...MediaMetadata }",
"fragment _IContent on _IContent { _deleted _fulltext _modified _score _id _track _metadata {...IContentMetadata} }",
"fragment ct1 on ct1 { __typename lin { url { ...ContentUrl }} ric { html, json } lin2 { url { ...ContentUrl }} ric2 { html, json } ..._IContent }",
"fragment ct1 on ct1 { __typename lin { text title target url { ...ContentUrl }} ric { html, json } lin2 { text title target url { ...ContentUrl }} ric2 { html, json } ..._IContent }",
]
`);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-cms-sdk/src/graph/createQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function convertPropertyField(
fields.push(`${name} { ...ContentUrl }`);
} else if (property.type === 'link') {
extraFragments.push(CONTENT_URL_FRAGMENT);
fields.push(`${name} { url { ...ContentUrl }}`);
fields.push(`${name} { text title target url { ...ContentUrl }}`);
} else if (property.type === 'contentReference') {
extraFragments.push(CONTENT_URL_FRAGMENT);
fields.push(`${name} { key url { ...ContentUrl }}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-cms-sdk/src/infer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export type InferFromProperty<T extends AnyProperty> =
: T extends JsonProperty ? any
: T extends RichTextProperty ? InferredRichText
: T extends UrlProperty ? InferredUrl
: T extends LinkProperty ? { url: InferredUrl }
: T extends LinkProperty ? { text: string | null, title: string | null, target: string | null, url: InferredUrl }
: T extends IntegerProperty ? number
: T extends FloatProperty ? number
: T extends ContentReferenceProperty ? { url: InferredUrl }
Expand Down
Loading