feat(p2p): preconfirmed p2p network scaffolding - part 1#3369
Merged
Conversation
CHr15F0x
force-pushed
the
chris/p2p-sync-test-improvements
branch
from
754fedb to
6950607
Compare
CHr15F0x
force-pushed
the
chris/preconfirmed-p2p-network-scaffolding
branch
2 times, most recently
from
d75fbbb to
ecc0e8a
Compare
CHr15F0x
force-pushed
the
chris/preconfirmed-p2p-network-scaffolding
branch
from
5edfb02 to
ea24acb
Compare
zvolin
approved these changes
Apr 29, 2026
Contributor
zvolin
left a comment
zvolin
left a comment
There was a problem hiding this comment.
hard to say anything at this stage 😅 ship it I guess? (p.s. I'd squash)
CHr15F0x
force-pushed
the
chris/preconfirmed-p2p-network-scaffolding
branch
from
ea24acb to
99f572c
Compare
Contributor
Author
Squashed. |
CHr15F0x
force-pushed
the
chris/preconfirmed-p2p-network-scaffolding
branch
from
99f572c to
5b85250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preconfirmed P2P network tracking issue: #3349
Fixes: #3376
This PR adds a submodule to the
p2pcrate. The network behavior contrains plain gossipsub and no message encoding scheme is used. Just a null byte is sent for sanity testing.I'd like to add 2 more follow up PRs (so far):