Skip to content

#43 - Remove fix references from web display and image regression tests#46

Open
MartinVazquez1982 wants to merge 7 commits into
equodev:mainfrom
MartinVazquez1982:main
Open

#43 - Remove fix references from web display and image regression tests#46
MartinVazquez1982 wants to merge 7 commits into
equodev:mainfrom
MartinVazquez1982:main

Conversation

@MartinVazquez1982

Copy link
Copy Markdown

Three independent issues were preventing WizardDialog from opening in web mode:

  • Mispositioned dialog: DartDisplay.getPrimaryMonitor() returned a Monitor with uninitialized bounds, placing the dialog at negative coordinates. Aligned it with the existing behavior in getMonitors().
  • NullPointerException on image load: In web mode, getImagePath(100) returns null for bundle resources. The DartImage constructor now throws SWTException in that case, letting JFace fall back to its InputStream path instead of crashing.
  • Unhandled SVG load failure: With no SVGRasterizer on the classpath, loading SVG icons via imageDataProvider was throwing an uncaught SWTException. Now falls back to a 1×1 placeholder so the wizard opens, even if JFace icons don't render.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants