Skip to content

fix: route token-aware setBudget hook payload#24

Closed
tsubasakong wants to merge 2 commits into
erc-8183:mainfrom
tsubasakong:split/base-hook-payload-fix
Closed

fix: route token-aware setBudget hook payload#24
tsubasakong wants to merge 2 commits into
erc-8183:mainfrom
tsubasakong:split/base-hook-payload-fix

Conversation

@tsubasakong
Copy link
Copy Markdown

@tsubasakong tsubasakong commented Apr 14, 2026

Summary

  • route BaseACPHook setBudget callbacks using ACP's token-aware payload
  • update BiddingHook and FundTransferHook to match the token-aware callback signature

Why

  • ACP core encodes setBudget hook data as abi.encode(caller, token, amount, optParams), but BaseACPHook still decoded the older payload shape
  • split this foundational fix out of feat: add UnderwritingHook #16 so it can be reviewed independently from the underwriting workflow scaffold

Test Plan

  • forge build

@tsubasakong tsubasakong changed the title [codex] fix: route token-aware setBudget hook payload fix: route token-aware setBudget hook payload Apr 14, 2026
@tsubasakong tsubasakong marked this pull request as ready for review April 15, 2026 04:29
@ariessa
Copy link
Copy Markdown
Collaborator

ariessa commented May 4, 2026

Closing this PR as issue is already solved in current commit in main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants