fix: encode success flag in EXECTYPE_TRY return data#52
Open
abhicris wants to merge 1 commit intoerc7579:mainfrom
Open
fix: encode success flag in EXECTYPE_TRY return data#52abhicris wants to merge 1 commit intoerc7579:mainfrom
abhicris wants to merge 1 commit intoerc7579:mainfrom
Conversation
When execType == EXECTYPE_TRY, the bytes[] returned by executeFromExecutor now encodes each element as abi.encode(bool success, bytes returnData), allowing the calling executor module to distinguish successful return data from revert data. Fixes erc7579#51 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytes[]returned by_tryExecute(batch) and the single-call TRY path inexecuteFromExecutorasabi.encode(bool success, bytes returnData)abi.decode(returnData[i], (bool, bytes))to distinguish successful results from revert dataTryExecuteUnsuccessfulevent continues to be emitted for failed calls (no change)Fixes #51
Test plan
EXECTYPE_DEFAULT, notEXECTYPE_TRY, so are unaffected)executeFromExecutorwithEXECTYPE_TRYon a batch where one call reverts, decodereturnData[i]and verifysuccess == falsefor the failing call🤖 Generated with Claude Code