Skip to content

Implemented Custom Grouping#161

Open
TheArmagan wants to merge 3 commits into
erich666:masterfrom
TheArmagan:master
Open

Implemented Custom Grouping#161
TheArmagan wants to merge 3 commits into
erich666:masterfrom
TheArmagan:master

Conversation

@TheArmagan
Copy link
Copy Markdown

@TheArmagan TheArmagan commented Apr 16, 2026

Implemented the custom grouping settings that allows you to actually specify which blocks you want to export one by one or as in group.

image image

Added Custom Grouping UI and settings dialog, wired per-block export behavior into the OBJ/USD export pipeline, fixed individual block grouping and naming, added material list search and subtype-aware handling for shared block families like Copper Ore and Moss Block, and adjusted the export dialog layout to fit the new controls cleanly.
@erich666
Copy link
Copy Markdown
Owner

Thanks for working on this, but I don't quite understand the feature. So if you check Custom grouping you get a dialog and can choose whether a type gets grouped or made into individual blocks?

This commit is quite hard to read, as a lot of the "changes" are just reformatting changes, no real change to the code. For example, ObjManip.cpp is shown as "+7,575 -5,837" - that's 7575 lines added, 5837 subtracted. Mineways.cpp has +2,618 -1,881. This makes it almost impossible for me to evaluate the actual code changes, so I think I have to pass on folding this one into the code for now. If you want to resubmit with only the true changes, that would go a long way towards me being able to understand what you're adding and folding it in.

@TheArmagan
Copy link
Copy Markdown
Author

So if you check Custom grouping you get a dialog and can choose whether a type gets grouped or made into individual blocks?

Yes

I will eventually do better commit some-day but not yet. It currently functions good enough for me I needed to make this for my small game project where player's able to mine specific areas.

@erich666
Copy link
Copy Markdown
Owner

Thanks. This does seem quite specialized, so I'm not sure I want to add it as a (somewhat complex) feature, but I'll at least mention it on the Mineways Discord channel for now. I hope to have more time in the summer where I can try it out. Very cool that you've added a feature! Now I'm feeling a bit guilty about the groups I've made in some cases, where a bunch of simple block types all get lumped in together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants