Allow loading as ES6 module#11
Open
letorbi wants to merge 2 commits intoericktatsui:masterfrom
Open
Conversation
Author
|
@ericktatsui Hi, again :) Is there any change that this PR will be merged? The changes helped me when reviving two old projects already, so it would be great, if you would consider merging them even though Touch-Menu-Like-Android is not in active development anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to load the code as an ES6 module, by adding the main function
TouchMenuLAexplicitly to thewindowobject. This should not change any behavior and cause no unwanted side-effects.Apart from that the
mainvalue in package.json has been set to the minimized script to avoid the need to specify the full path to the JS file.Once the PR is merged, the the JS code for the touch menu can be loaded as follows:
The CSS still needs to be loaded as before.
I've just ported an app for hangboard training from Cordova to Capacitor, which required this little change to make it work again, and thought that it might be helpful for others as well...