Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions frontend/src/components/scan/ScanResultView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ export function FadeSlideIn({
}: Readonly<{ children: React.ReactNode; delay?: number }>) {
const prefersReduced = useReducedMotion();
const [visible, setVisible] = useState(false);
useEffect(() => { setVisible(true); }, []);
// setState inside requestAnimationFrame is asynchronous, so it does not
// violate react-hooks/set-state-in-effect while still triggering the
// mount-time fade-in transition.
useEffect(() => {
const id = requestAnimationFrame(() => setVisible(true));
return () => cancelAnimationFrame(id);
}, []);

if (prefersReduced) return <>{children}</>;

Expand Down Expand Up @@ -213,8 +219,10 @@ export function ScanFoundView({
// Animated score count-up
useEffect(() => {
if (prefersReduced || tryVitScore === 0) {
setDisplayScore(tryVitScore);
return;
// Defer to next frame so the setState is asynchronous (see
// react-hooks/set-state-in-effect). Visual outcome is unchanged.
const id = requestAnimationFrame(() => setDisplayScore(tryVitScore));
return () => cancelAnimationFrame(id);
}
let frame: number;
const start = performance.now();
Expand Down
Loading