[SharovBot] fix: add 0x prefix to structLogs storage keys/values in debug_traceCall#20753
Closed
erigon-copilot[bot] wants to merge 1 commit into
Closed
[SharovBot] fix: add 0x prefix to structLogs storage keys/values in debug_traceCall#20753erigon-copilot[bot] wants to merge 1 commit into
erigon-copilot[bot] wants to merge 1 commit into
Conversation
…ebug_traceCall
The EVM struct log serialization in debug_traceCall was returning storage
slot keys and values without the 0x hex prefix, causing mismatches with
reference node implementations.
Affected files:
- rpc/ethapi/api.go: FormatLogs() used fmt.Sprintf("%x") instead of .Hex()
- execution/tracing/tracers/logger/logger.go: same FormatLogs() duplicate
- execution/tracing/tracers/logger/json_stream.go: WriteObjectField/WriteString
used raw hex.Encode without 0x prefix instead of common.Hash.Hex()
Fix: use common.Hash.Hex() which includes the 0x prefix consistently.
Fixes mainnet-rpc-integ-tests-latest debug_traceCall/test_43 failure on release/3.4.
Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
erigon-copilot
Bot
requested review from
canepat,
lupin012,
mh0lt and
yperbasis
as code owners
Member
|
Closing in favour of #20749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SharovBot]
Summary
Fixes consistently failing
mainnet-rpc-integ-tests-latestonrelease/3.4— specificallydebug_traceCall/test_43which was reporting storage key/value mismatches.Root Cause
The EVM struct log serialization was returning storage slot keys and values without the
0xhex prefix, causing mismatches with the reference node:Files Changed
rpc/ethapi/api.go:FormatLogs()— usedfmt.Sprintf("%x", i)instead ofi.Hex()execution/tracing/tracers/logger/logger.go: duplicateFormatLogs()— same fixexecution/tracing/tracers/logger/json_stream.go: streaming logger used rawhex.Encode()without0xprefix instead ofcommon.Hash.Hex()Fix
Replace all three occurrences with
common.Hash.Hex()which includes the0xprefix consistently.Testing
go test ./execution/tracing/tracers/... ./rpc/ethapi/...✅go build ./...compiles clean ✅debug_traceCall/test_43failure inmainnet-rpc-integ-tests-latest