Makefile: reject unsupported TARGET values - #157
Open
PhysicistJohn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Firmware target selection currently depends on where
TARGEToriginates.A command-line typo such as
make TARGET=TYPOis not overwritten by theMakefile. It falls through the later conditionals and silently produces an
F072 firmware image.
Conversely, an environment-supplied
TARGET=F072is overwritten with F303.Both cases can produce apparently valid firmware for the wrong MCU.
Change
Default an undefined
TARGETto F072 and accept exactly the two supportedvalues,
F072andF303. Any other value now produces a make-time error.Verification
Tested with GNU Make 3.81 and Arm GNU Toolchain 11.3.Rel1:
byte-for-byte identical to unmodified upstream
No firmware source or compiler flags are changed.