fix: initialize complete backup checksum image - #165
Merged
erikkaashoek merged 1 commit intoAug 4, 2026
Merged
Conversation
The RTC backup checksum covers every byte except the checksum itself, including a reserved packed byte that was never assigned. Its stack value could therefore make otherwise valid state fail verification after reset. Zero-initialize the complete backup image before assigning persisted fields so the checksum and reserved byte are deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The RTC backup checksum covers every byte of
backup_texcept the checksum byte itself. That range includes the packeddummy2reserved byte, but the stack-local structure is populated field-by-field and never initializes it.The checksum can therefore incorporate indeterminate stack data and cause otherwise valid analyzer settings to be rejected after reset.
Change
Zero-initialize the complete packed backup image before assigning its persisted fields. This makes the reserved byte and resulting checksum deterministic without changing the backup layout or checksum algorithm.
Verification
Scope and limitations