Repository navigation
Business hours schedule select on SLA policy and department forms - #209
Merged
Merged
Conversation
… forms Shown only when the backend passes a schedules list; posts business_schedule_id (null for the default). Pages rendered without the list are unchanged and never send the field.
npm audit fix: vite, vitest/@vitest/mocker and follow-redirects, lockfile only.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backends now let an SLA policy and a department name the business schedule their business-hours deadlines count in (precedence: policy, then the ticket's department, then the default schedule). See escalated-laravel #256 and escalated-nestjs #168.
What changes
Admin/SlaPolicies/FormandAdmin/Departments/Formaccept an optionalschedulesprop ([{ id, name }]).null) plus each schedule, bound tobusiness_schedule_idand preselected from the saved record. Validation errors on the field are shown.pages.jsonregenerated (schedulesadded to both forms' props). CHANGELOG[Unreleased]entry.Tests
tests/pages/AdminBusinessScheduleSelect.test.jsruns the same cases against both forms: no prop (no select, nothing posted, including for a saved record with a schedule), the options,nullfor the default, the chosen id, and switching a saved schedule back to the default.Full vitest,
npm run lint,npm run format:check,npm run pages:checkpass locally (the packaging test needsnpm pack, exercised in CI).The Laravel side that passes
schedulesis a follow-up PR in escalated-laravel.Also
The Node 22 job's
npm auditstep started failing on advisories published since main last ran (vite, vitest/@vitest/mocker, follow-redirects). A second commit runsnpm audit fix(lockfile only, within existing ranges);npm auditreports 0 vulnerabilities.