Repository navigation
Webhook form: has_secret, Remove secret; SSO masked-secret hints - #210
Merged
Merged
Conversation
The webhook form leaves the secret blank when the backend sends has_secret, says a secret is set, and offers Remove secret (clear_secret: true). Backends that still send secret keep the old behaviour. The SSO page says when a masked secret is stored.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend half of the stored-secrets fix (escalated-laravel #258).
Webhooks form (
Admin/Webhooks/Form)webhookprop carrieshas_secret, the secret field starts blank and, if a secret is stored, says "A secret is set. Leave blank to keep it." with a Remove secret button. Remove postsclear_secret: true(with Keep secret to undo); otherwise the form postsclear_secret: false, and a blank secret keeps the stored one on the backend.secret(nohas_secretkey) behave exactly as before: the field is filled in, posted back as it is, andclear_secretis never sent.form.errors.secretif the backend returns one.SSO settings (
Admin/Settings/SsoSettings)********), a hint says a secret is set and that leaving the field alone keeps it. The mask is posted back unchanged, which backends now treat as "keep". Inputs getautocomplete="new-password"so browsers do not autofill a saved password into them.Tests:
tests/pages/AdminStoredSecrets.test.js(10 cases: has_secret blank/keep/replace/remove/undo, no stored secret, legacysecretbackend, create, SSO masked hints and post-back). Full vitest suite green locally excepttests/packaging.test.js, which fails identically onmainlocally (npm packenvironment issue) and runs in CI.