Repository navigation
Admin users page: show optional server notice - #212
Merged
Merged
Conversation
Admin/Users/Index accepts an optional notice string. escalated-nestjs sends one when the host has not configured a user-list hook; the page shows it as an informational status message above the table, in place of the empty state. The text is rendered as given (escaped, not translated). Without the prop the page is unchanged.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
escalated-nestjs #180 sends an optional
noticestring toEscalated/Admin/Users/Indexwhen the host has not configured a user-list hook.noticeis non-empty, the page shows it as an informationalrole="status"message above the table (blue variant of the existing banner style) and drops the "No users found." row.notice: unchanged behaviour.pages.jsonregenerated (noticeadded to the page's props, not required).tests/pages/AdminUsersIndex.test.js(5 cases: notice shown, escaped, alongside rows, absent, empty).