Skip to content

Fix keepdims handling in layout_patterns.py#4

Open
fwsmit wants to merge 1 commit into
espressif:masterfrom
fwsmit:patch-1
Open

Fix keepdims handling in layout_patterns.py#4
fwsmit wants to merge 1 commit into
espressif:masterfrom
fwsmit:patch-1

Conversation

@fwsmit

@fwsmit fwsmit commented Jun 16, 2026

Copy link
Copy Markdown

Description

Add default value with the same pattern as esp_ppq/executor/op/torch/default.py. I didn't check every operator, but I believe keepdims should always default to 1. Here's an example in the ONNX docs: https://onnx.ai/onnx/operators/onnx__ReduceMean.html.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Add default value with the same pattern as esp_ppq/executor/op/torch/default.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant