Segment Lab Explore gallery by experimental phase#369
Open
tkaragianes wants to merge 2 commits intodevfrom
Open
Segment Lab Explore gallery by experimental phase#369tkaragianes wants to merge 2 commits intodevfrom
tkaragianes wants to merge 2 commits intodevfrom
Conversation
Member
|
Potential concern: We pull back one page of labs at a time, ordered by status then date. What happens when the first page is all in one category but the user goes to look at a different category? Additionally, how does that play with the infinite-scroll logic? |
Contributor
|
Will all successfully completed labs appear under Results Posted regardless of date? I like the layout as long as all labs with results are grouped under that tab and only suspended labs are grouped under Archived. I assume labs will continue to be organized by date within each tab. Two-year timescale is good for archive status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the lab page easier to understand, highlighting the labs that are currently accepting submissions and giving context for other labs based on their phase in the experimental pipeline.
Before:

After:

Implementation Notes
The LabExplore page now uses a computed property to segment the labs by experimental phase, and displays the lab cards in collapsible sections. Any lab without an experimental phase or that is older than 2 years (just a suggested timescale, can easily adjust) is placed into an "Archived" section, as some old labs are paused at various stages of the experimental pipeline.
Testing
Visually verified on local environment.
Related Issues
Closes #94.