admin: parsed JSONC settings editor (takes over #7666, closes #7603)#7709

Open

JohnMcLear wants to merge 32 commits intoether:developfrom

JohnMcLear:takeover/7666-admin-settings-editor

Commits on May 9, 2026

admin: improve settings editor UX and restore comments (#7603)
AyushiGupta160604
committed
admin(settings): address review of #7666 — types, focus, i18n, tests

JohnMcLear
and
claude
committed
docs: design spec for admin /settings parsed view

JohnMcLear
and
claude
committed
docs: implementation plan for admin /settings parsed view

JohnMcLear
and
claude
committed
admin(settings): add jsonc-parser dep

JohnMcLear
and
claude
committed
admin(settings): pure helpers for env pills and comment extraction

JohnMcLear
and
claude
committed
admin(settings): editJsonc wrapper around jsonc-parser modify

JohnMcLear
and
claude
committed
admin(settings): leaf widgets (string, number, bool, null, env pill)

JohnMcLear
and
claude
committed
admin(settings): group widgets, JsoncNode dispatcher, CommentLabel

JohnMcLear
and
claude
committed
admin(settings): FormView, ParseErrorBanner, ModeToggle

JohnMcLear
and
claude
committed
admin(settings): toggle FormView and raw textarea from SettingsPage

JohnMcLear
and
claude
committed
admin(settings): styles for tree, widgets, env pill, parse error

JohnMcLear
and
claude
committed
admin(settings): i18n keys for form mode, parse error, env pill

JohnMcLear
and
claude
committed
admin(settings): playwright specs for form view, env pill, parse error, round-trip

JohnMcLear
and
claude
committed
admin(settings): don't read trailing comments past end-of-line

JohnMcLear
and
claude
committed
admin(settings): schema-driven help text from settings.json.template

JohnMcLear
and
claude
committed
admin(settings): redesign form view as light two-column form

JohnMcLear
and
claude
committed
admin(settings): update specs for label/help split + template fallback

JohnMcLear
and
claude
committed
fix(#2): use stable React keys derived from AST node offsets/property keys

JohnMcLear
and
claude
committed
fix(#3): read latest settings text from store in onEdit to prevent stale closures

JohnMcLear
and
claude
committed
fix(#6): resolve .settings CSS conflict between App.css and index.css

JohnMcLear
and
claude
committed
fix(#8): suppress parse-error flash while settings are still loading

JohnMcLear
and
claude
committed
fix(#9): sync NumberInput draft state with value prop when not focused

JohnMcLear
and
claude
committed
docs(#10): aria-describedby already resolved during form redesign

JohnMcLear
and
claude
committed
docs(#11): add comment explaining handleKeyDown Tab/rAF behaviour

JohnMcLear
and
claude
committed
fix(#12): show save toast on server ack only, not optimistically

JohnMcLear
and
claude
committed
fix(#13): strengthen saveSettings helper to wait for genuine new toast open

JohnMcLear
and
claude
committed
fix(#14): internationalise hard-coded UI strings in FormView and ModeToggle

JohnMcLear
and
claude
committed
fix(#15): default IconButton type to 'button' to prevent accidental form submit

JohnMcLear
and
claude
committed
fix(#7): change protocol-relative GitHub wiki links to explicit https://

JohnMcLear
and
claude
committed
admin(settings): inline template at build time, drop fs.allow widening

JohnMcLear
and
claude
committed

Commits on May 10, 2026

Merge remote-tracking branch 'origin/develop' into takeover/7666-admin-settings-editor
JohnMcLear
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

admin: parsed JSONC settings editor (takes over #7666, closes #7603)#7709

admin: parsed JSONC settings editor (takes over #7666, closes #7603)#7709
JohnMcLear wants to merge 32 commits intoether:developfrom
JohnMcLear:takeover/7666-admin-settings-editor

Commits on May 9, 2026

admin: improve settings editor UX and restore comments (#7603)

admin(settings): address review of #7666 — types, focus, i18n, tests

docs: design spec for admin /settings parsed view

docs: implementation plan for admin /settings parsed view

admin(settings): add jsonc-parser dep

admin(settings): pure helpers for env pills and comment extraction

admin(settings): editJsonc wrapper around jsonc-parser modify

admin(settings): leaf widgets (string, number, bool, null, env pill)

admin(settings): group widgets, JsoncNode dispatcher, CommentLabel

admin(settings): FormView, ParseErrorBanner, ModeToggle

admin(settings): toggle FormView and raw textarea from SettingsPage

admin(settings): styles for tree, widgets, env pill, parse error

admin(settings): i18n keys for form mode, parse error, env pill

admin(settings): playwright specs for form view, env pill, parse error, round-trip

admin(settings): don't read trailing comments past end-of-line

admin(settings): schema-driven help text from settings.json.template

admin(settings): redesign form view as light two-column form

admin(settings): update specs for label/help split + template fallback

fix(#2): use stable React keys derived from AST node offsets/property keys

fix(#3): read latest settings text from store in onEdit to prevent stale closures

fix(#6): resolve .settings CSS conflict between App.css and index.css

fix(#8): suppress parse-error flash while settings are still loading

fix(#9): sync NumberInput draft state with value prop when not focused

docs(#10): aria-describedby already resolved during form redesign

docs(#11): add comment explaining handleKeyDown Tab/rAF behaviour

fix(#12): show save toast on server ack only, not optimistically

fix(#13): strengthen saveSettings helper to wait for genuine new toast open

fix(#14): internationalise hard-coded UI strings in FormView and ModeToggle

fix(#15): default IconButton type to 'button' to prevent accidental form submit

fix(#7): change protocol-relative GitHub wiki links to explicit https://

admin(settings): inline template at build time, drop fs.allow widening

Commits on May 10, 2026

Merge remote-tracking branch 'origin/develop' into takeover/7666-admin-settings-editor