Standardize provider contract address storage#336
Open
its-applekid wants to merge 9 commits into
Open
Conversation
👷 Deploy request for actions-ui pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors all provider contract address storage to follow a consistent
{ contracts, metadata }pattern, enabling automated address validation through abstract methods on base classes.Changes
Phase 1: Restructured Address Maps
{ contracts, metadata }pattern{ contracts, metadata }pattern{ contracts, metadata }patternPhase 2: Abstract Methods
abstract contractAddresses()toSwapProviderabstract contractAddresses()toLendProviderPhase 3: Provider Implementations
contractAddresses()inUniswapSwapProvidercontractAddresses()inAaveLendProvidercontractAddresses()inMorphoLendProviderPhase 4: Test Updates
validateAddresses.test.tsto use generic provider iterationcontractAddresses()to mock providersBenefits
contractAddresses(){ contracts, metadata }patternTesting
Closes
Closes #328