Align lend amount types with swap pattern#346
Closed
its-applekid wants to merge 11 commits into
Closed
Conversation
👷 Deploy request for actions-ui pending review.Visit the deploys page to approve it
|
Contributor
|
Thanks. Closing in favor of #347. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns lend module type patterns with the swap module's consistent input/output amounts, resolving issue #303.
Closes #303
Changes
SDK Types
amountRaw: bigint, changedamountfrombiginttonumber(human-readable)balance/sharesfrombiginttonumber, addedbalanceRaw/sharesRawamount: bigint→amountRaw: bigintfor consistencyProviders
amountRawparameterPrinciple
Developers pass human-readable numbers in, receive human-readable numbers out with the same field names. Raw bigint values are always suffixed with
Raw.Verification
Breaking Changes
This is a breaking change to the public API:
LendTransaction.amountis nownumberinstead ofbigintLendTransaction.amountRawfield for raw bigint valuesLendMarketPosition.balance/sharesare nownumberinstead ofbigintLendMarketPosition.balanceRaw/sharesRawfieldsLendClosePositionParams.amountrenamed toamountRaw