Fusaka banner #16644
Open
Fusaka banner #16644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…LinkOverlay for improved link handling
…adding a subtitle for clarity on network upgrade
… and user experience, including adjustments to text sizes and hover effects on links.
…nts for network upgrade, description, and countdown status to enhance localization support.
…ptions and status messages for the Ethereum network upgrade across multiple languages to enhance user experience and accessibility.
github-actions
bot
added
content 🖋️
…proved responsiveness, ensuring consistent styling across different screen sizes.
Fusaka hero translations
wackerow
approved these changes
Nov 19, 2025
pettinarip
reviewed
Nov 19, 2025
| </LinkBox> | ||
|
|
||
| <div className="relative z-0 h-[240px] overflow-hidden md:h-[480px]"> | ||
| <Image |
Member
There was a problem hiding this comment.
This image does not follow the optimizations implemented in the HomeHero component. I’d suggest either extending HomeHero and passing the Fusaka image as a prop, or updating it here (though that would duplicate some code).
|
|
||
| return ( | ||
| <div className="relative w-full"> | ||
| <LinkBox className="bg-[#333369] p-2 text-center text-white"> |
Member
There was a problem hiding this comment.
To be honest, I’m not a fan of this banner from a design perspective.
- It doesn’t follow our standard padding
- The justify-between layout feels unbalanced and creates too much empty space
- The background color lacks sufficient contrast and uses a custom value outside the design system
Proposal:
- Use justify-center
- Use bg-primary-low-contrast
- Apply text-body-inverse on the parent and keep defaults for nested elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates banner for Fusaka