eth: add eth_config API definitions for EIP-7910#678
eth: add eth_config API definitions for EIP-7910#678shemnon wants to merge 8 commits intoethereum:mainfrom
Conversation
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs. Changes: - Add eth_config method definition in src/eth/client.yaml - Add ConfigurationResponse, ConfigObject, and BlobSchedule schemas - Add bytes4 base type for CRC-32 hashes and fork IDs - Add test cases for different scenarios
Signed-off-by: Danno Ferrin <danno@numisight.com>
Co-authored-by: Mercy Boma Naps Nkari <96525594+bomanaps@users.noreply.github.com>
Co-authored-by: Mercy Boma Naps Nkari <96525594+bomanaps@users.noreply.github.com>
- Remove configHash fields from ConfigurationResponse - Move forkId fields into ConfigObject - Invert precompiles map: name->address mapping with alphabetical sorting - Update test cases to match EIP specification format Signed-off-by: Danno Ferrin <danno@numisight.com>
…cution-apis into eip-7910-eth_config Signed-off-by: Danno Ferrin <danno@numisight.com>
…scheduled. Signed-off-by: Danno Ferrin <danno@numisight.com>
lightclient
left a comment
lightclient
left a comment
There was a problem hiding this comment.
Generally LGTM. How were the tests generated? Would be good if we have that in rpctestgen before merging.
|
Tests were generated from the reference implementation and cross-compared with fork definitions. |
fjl
changed the title
|
We have to create these tests with rpctestgen before merging this. |
|
@shemnon - any chance you'd be willing to update this PR, resolve conflicts, and generate tests via rpctestgen (now in this repo)? |
|
It was up to date 8 months ago when I was working on it and still doing eth dev work. I don't have the time and am quite frustrated that this was presented as a blocking issue last year for the EIP and then was ignored when I jumped through the core-dev hoop. |
We’re really sorry about how this process played out. At the moment, our main blocker is getting the test If you’re okay with it, I can also open a new PR and regenerate the |
|
I have zero time I can commit to Ethereum core development at the moment. Do what needs to be done. |
6 participants
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs.
Changes: