error-groups, tools, tests: add spec-mandated error-code fixtures for methods#784
Open
simsonraj wants to merge 2 commits into
Open
error-groups, tools, tests: add spec-mandated error-code fixtures for methods#784simsonraj wants to merge 2 commits into
simsonraj wants to merge 2 commits into
Conversation
Added test fixtures for the error codes
4 tasks
Contributor
|
From RPC Standards call: Ideally, we need to get a go-ethereum PR to fix, so we can remove the error code overwriting logic from the generator, and then update the go-ethereum target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #650 that turns the new error-code catalog into a forcing function for client adoption via hive's
rpc-compatsimulator.txpool-errors.yaml.ExpectErrorCodeto the testgen. When set, rpctestgen rewrites the capturederror.codein the generated.iofixture to the spec-mandated valueeth_sendRawTransactionerror scenarios, each tagged with its catalog code.error.codeagainst the method's resolvederrors[]; emits[WARN]on unknown codes.Scenarios
send-nonce-too-lowExecutionErrorssend-intrinsic-gas-too-lowGasErrorssend-tx-gas-exceeds-block-limitGasErrorssend-tip-above-fee-capGasErrorssend-insufficient-fundsGasErrorssend-already-knownTxPoolErrorssend-replacement-underpricedTxPoolErrorsMeasured on docker-ized
go-ethereum,hyperledger/besu,nethermind/nethermind(full data and fixtures: simsonraj/eth-err-tests).Deferred
Four scenarios that can't yet be reliably reproduced across all clients because hive doesn't expose the relevant client-launch flags. (commented currently)