engine: add Rest-SSZ spec#793
Draft
MariusVanDerWijden wants to merge 5 commits intoethereum:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been multiple attempts at this already.
Moving away from JSON-RPC to REST-SSZ.
However most kept the engine api as is.
I think we have a good shot at refactoring the engine api with this change.
This Draft does that; the move and the refactoring.
Happy for any feedback I can get!
The core of the change is:
engine_newPayloadV{1..5}POST /{fork}/payloadsparentBeaconBlockRootandexecutionRequestsfolded into the SSZ envelope;expectedBlobVersionedHashesremoved;INVALID_BLOCK_HASHremoved from the status enumengine_forkchoiceUpdatedV{1..4}POST /{fork}/forkchoicepayload_attributes, and (Amsterdam+) optionalcustody_columnsengine_getPayloadV{1..6}GET /{fork}/payloads/{id}engine_getPayloadBodiesByHashV{1,2}POST /{fork}/bodies/hash{fork}selects the response schema (not the era of requested blocks);POSTbecause hash lists are too large for URLsengine_getPayloadBodiesByRangeV{1,2}GET /{fork}/bodies?from=...&count=...{fork}selects the response schemaengine_getBlobsV1POST /blobs/v1engine_getBlobsV2POST /blobs/v2engine_getBlobsV3POST /blobs/v3engine_getBlobsV4POST /blobs/v4engine_getClientVersionV1GET /identity+X-Engine-Client-Versionrequest headerengine_exchangeCapabilitiesGET /capabilitiesengine_exchangeTransitionConfigurationV1