Skip to content

Netlify deploy previews - #588

Merged
IstoraMandiri merged 5 commits into
ethereumclassic:masterfrom
IstoraMandiri:netlify-deploy-previews
Sep 12, 2026
Merged

IstoraMandiri merged 5 commits into
ethereumclassic:masterfrom
IstoraMandiri:netlify-deploy-previews

Conversation

@IstoraMandiri

Copy link
Copy Markdown
Contributor

Adds a Netlify config so every pull request gets a deploy preview, without Netlify ever publishing the production site (which stays on GitHub Pages). The build runs the same Jekyll command as CI, is skipped for all contexts except deploy-preview, installs gems explicitly so CLI-triggered builds work, and pins Ruby 3.2.9 plus Bundler 2.4.19 because the current lockfile's Bundler 2.1.4 crashes on Ruby 3.x. The Bundler pin can be dropped once #583 lands.

Ref #587

IstoraMandiri and others added 3 commits September 11, 2026 00:41
Build with the same command and flags as the Jekyll CI workflow, publish
_site, and pin Ruby 3.2.9 to match the CI runners.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Skip every deploy context except deploy-preview so production is never
published from Netlify. Run bundle install as part of the build command
so CLI- and agent-triggered builds do not fail with a missing jekyll
binary. Pin Bundler 2.4.19 because the current lockfile's BUNDLED WITH
2.1.4 overflows the stack on Ruby 3.x.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@netlify

netlify Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for ecips ready!

Name Link
🔨 Latest commit 42b4833
🔍 Latest deploy log https://app.netlify.com/projects/ecips/deploys/6aa4a198fc312e0008db1121
😎 Deploy Preview https://deploy-preview-588--ecips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

With JEKYLL_ENV=production, jekyll-github-metadata rewrites site.baseurl
from the GitHub Pages API. On Netlify that lookup fails and the gem falls
back to /pages/<owner>/<repo>, which prefixed every link and stylesheet
in deploy preview 588 and broke the page. CI never sets JEKYLL_ENV, so
match it explicitly.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@IstoraMandiri
IstoraMandiri requested a review from a team September 11, 2026 02:10

@diega diega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature. Thanks!

@IstoraMandiri
IstoraMandiri merged commit cad0aec into ethereumclassic:master Sep 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants