ci: add staging smoke test job before production release - #365
Merged
maugauwi-hash merged 1 commit intoAug 31, 2026
Merged
Conversation
|
@rudeus112266 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a staging smoke-test job (
scripts/smoke_test_staging.sh+.github/workflows/staging-smoke-test.yml) that exercises core flows — auth,GET /vaults,POST /vaults/{id}/checkin— against a staging deployment, to catch a backend/clientshared/api-contract.mdmismatch before a release build ships.Context / design note
android-ci.ymlandios-ci.ymlonly cover build/test/lint, and there is no release-cut workflow in this repo yet to gate directly. Rather than invent a release workflow out of scope for this change, the smoke-test job is exposed viaworkflow_call(see comment in the workflow file) so that whichever workflow eventually cuts a release can add:Auth is verified via a long-lived smoke-test-account JWT (
STAGING_SMOKE_TOKENsecret) rather than a live WebAuthn ceremony, since passkey signing isn't automatable in CI. The check-in call follows the anti-replay header contract (X-Nonce,X-Timestamp) documented inshared/api-contract.md.Also documents the staging environment's relationship to
API_BASE_URLin README.md — staging is a fixed CI-only target, distinct from the per-clientAPI_BASE_URLconfigured inInfo.plist/build.gradle.kts.Testing
bash -n scripts/smoke_test_staging.sh— syntax check passesSTAGING_API_BASE_URL/STAGING_SMOKE_TOKEN/STAGING_SMOKE_VAULT_IDsecrets don't exist in this fork — these need to be provisioned in the upstream repo's Actions secrets for the job to run for real.Closes #308