feat: add structured request logging with request IDs and configurable levels#16
Open
reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
Open
feat: add structured request logging with request IDs and configurable levels#16reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds structured request logging middleware to improve observability across the MCP server and proxy.
Features
1. HTTP Request Logging
method: HTTP method (GET, POST, etc.)path: Request pathstatus: HTTP response status codeduration_ms: Request duration in millisecondsuser_agent: Client user agentremote_addr: Client IP addresssize: Response size in bytes2. Request ID Propagation
X-Request-IDheader3. Correlation IDs for Tracing
X-Correlation-IDheader for distributed tracing4. Configurable Log Levels
debug,info,warn,errorlevels5. JSON Logging Format
textandjsonformatsConfiguration
MCP Server (
config.yaml)Proxy Server (
proxy-config.yaml)Usage
The logging middleware is automatically applied to all HTTP routes when using SSE or streamable-http transport:
/sse,/message,/mcp,/health,/readyendpointsTesting
All new code includes comprehensive tests:
go test -v ./pkg/observability/...Example Output
Text Format
JSON Format
{ "level": "info", "msg": "HTTP request completed", "method": "GET", "path": "/mcp", "status": 200, "duration_ms": 45, "request_id": "abc-123", "user_agent": "mcp-client/1.0" }