feat: add comprehensive health check endpoints for server and plugins#14
Open
reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
Open
feat: add comprehensive health check endpoints for server and plugins#14reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
reldothescribe wants to merge 1 commit intoethpandaops:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive health check endpoints for the MCP server and plugins.
Changes
New Health Endpoints
/health- Overall server health{"status": "healthy", "version": "...", "timestamp": "..."}/health/ready- Readiness probe (server initialized)/health/live- Liveness probe (server running)/health/plugins- Per-plugin health statusPlugin HealthCheck Interface
HealthCheck()method to thePlugininterface inpkg/plugin/plugin.goHealthStatustype with constants:healthy,unhealthy,unknownHealthCheckResultstruct with status, message, and checked_at fieldsPlugin Implementations
Implemented
HealthCheck()for all existing plugins:Registry Updates
HealthChecks()method toplugin.Registryto aggregate health from all pluginsBackward Compatibility
/readyendpoint is preserved for backward compatibilityTests
Testing
Run the tests:
make testRelated
This implementation follows Kubernetes health probe conventions and provides a foundation for monitoring the MCP server in production environments.