Configurable OAuth success page via proxy config#51
Merged
Conversation
Move hardcoded special-user and org checks out of the client success page renderer into a config-driven rule system on the proxy. Rules match on org membership and/or username, and specify tagline text and media (GIF URL or base64 ASCII art). First matching rule wins, with an optional default fallback. The proxy resolves display fields during the OAuth callback and passes them to the client via redirect query params. The client renders whatever it receives instead of checking a hardcoded user list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
success_pageconfig block to proxy config for customizing the OAuth callback page. Rules match on org and/or username to resolve tagline text and media (GIF URL or base64 ASCII art), and the proxy passes the resolved fields to the client via redirect query params. Replaces the hardcoded special-user map and ethpandaops org checks — the client just renders whatever it receives now.