Use correct syntax for Nimbus EL custom networks#2682
Open
yorickdowne wants to merge 1 commit into
Open
Conversation
yorickdowne
force-pushed
the
fix-nimbus-el-custom
branch
from
f92be3b to
57b597a
Compare
Collaborator
Author
|
Tested with Sepolia metadata. Works for Nimbus EL. Expected to break for Nimbus Unified: They have an issue to improve things |
yorickdowne
force-pushed
the
fix-nimbus-el-custom
branch
from
57b597a to
9e8c5c4
Compare
Collaborator
Author
|
Adjusted to work with status-im/nimbus-eth1#4449 This'll break for Nimbus-Unified as released, but then it was breaking before. This form will start to work when their PR is merged, which is preferable to staying broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Nimbus EL custom path uses
--network. If--custom-networkwas correct in a previous version, it no longer isCorrect parsing of bootnodes to allow trailing comments, see https://github.com/eth-clients/sepolia/blob/main/metadata/enodes.yaml