Repo improvements analysis (2026-06-10) - #43
Merged
Conversation
Deep audit of the repo for correctness, drift, convention adherence, and improvement opportunities. Findings grouped P0/P1/P2 with file:line citations and concrete fixes. Analysis only — no other files changed. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
Add a clear "FICTIONAL STARTER DATA" banner comment to the top of each seeded ops/ file (pipeline, customers, daily-log, feedback-log, priorities, roadmap-signals), matching the convention demo/ already uses. A public visitor could otherwise read ops/customers.md — with ARR and renewal dates — as a leaked real customer book. The data is unchanged; only labelled. ops/icp.md is a placeholder template, so it needs no banner. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
The 7th hook (verify-after-change.sh) and its PostToolUse(Edit|Write) wiring shipped undocumented. Add it to the README hooks table and the "hooks earn their place" list, to CLAUDE.md's Hooks section, and as a CHANGELOG entry (with verify.sh.example). Correct the now-false counts: README "Five guardrails" -> six; "one uses python3" -> two (protect-files.sh and verify-after-change.sh both invoke python3; web-bootstrap.sh only mentions it in a comment). Mirror the python3 fix in CLAUDE.md. Reconcile the CHANGELOG effort-level entry with what ships: settings.json pins effortLevel "xhigh", not "high"; update the entry and rationale. Also note in the README ops/ row that the books ship pre-seeded with fictional, clearly-labelled accounts so the rituals run day one. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
config.yml linked langoptima.com/growth while README links langoptima.com/features/growth (twice). Standardize the issue-template contact link on langoptima.com/features/growth so all three in-repo CTA references match. Canonical value assumed from the in-repo majority and flagged for confirmation — see REPO-IMPROVEMENTS-2026-06-10.md "Held for Edwin's decision". https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
The feedback skills disagreed on where MARKETING-ACTION / RETENTION-RISK tags live: marketing-feedback said "the daily log", retention-feedback said "daily log / feedback log", account-health said "the feedback log" — while session-start.sh surfaces only ops/feedback-log.md and weekly-review clears from there. A tag written to the daily log was invisible to both, the same drift the kit's todo-single-source rule exists to prevent. Align all of them on ops/feedback-log.md as the one canonical home, and make morning-briefing and weekly-review name the file explicitly. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
Thornbury Insurance and Cascadia BioSciences appeared as both pre-sale deals (demo/pipeline.md) and signed customers (demo/customers.md + support-tickets.md), so /demo-briefing ran on contradictory data. They are woven through the customer book, support tickets, and meeting notes as live accounts, so resolve the contradiction in the pipeline's favour as intended: mark both pipeline rows as expansion deals on existing customers, add a header note explaining the land-and-expand pattern, and clarify the two meeting notes as expansion conversations. New-logo deals (Rheinkraft, Borealis, Tasman) stay out of the customer book. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
Record what the 2026-06-10 fix pass deliberately left for Edwin: the CTA URL confirmation, the Stop-hook visibility mechanism question, the undocumented security-guidance plugin, the 0.2.0 release call, and the two fixes blocked by environment file-protection (pre-commit-guard.sh added-lines-only, settings.json autoMemoryEnabled=false) with the exact edits to apply by hand. https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
- pre-commit-guard.sh: filter staged diff to added lines so removing a leaked secret is not itself blocked - settings.json: autoMemoryEnabled false (kit sessions carry prospect data) - mark both resolved in the improvements report https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
…t claim, cut 0.2.0 - stop-reminder.sh emits JSON systemMessage (stderr-on-exit-0 only shows as a hook-error notice) (P1.7) - Remove undocumented security-guidance plugin so the kit runs anywhere out of the box (P1.8) - Correct PreCompact re-injection claim in README/CLAUDE.md; credit SessionStart as the durable path - CHANGELOG: roll [Unreleased] + this pass's fixes under 0.2.0 (tag v0.2.0 at merge) (P2.7) https://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
…nts-analysis-znudrv # Conflicts: # CHANGELOG.md
etrebels
marked this pull request as ready for review
June 10, 2026 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
REPO-IMPROVEMENTS-2026-06-10.md— a deep audit of the public giveaway kit. Analysis only; no other files changed. Findings grouped P0/P1/P2 withfile:linecitations and concrete fixes.Headline findings
ops/data is unlabelled. Vantyr / Kessler Pharma / Nordvik with ARR, renewal dates, churn notes (ops/pipeline.md:5-12,ops/customers.md:8-14) carry no "fictional" banner — unlikedemo/. To a visitor it's indistinguishable from a real customer book. One comment line per file fixes it.README.md:134/140…/features/growthvs issue-template…/growth— one 404s); undocumented 7th hook (verify-after-change.sh) makes "five guardrails"/"one uses python3" false; real bug inpre-commit-guard.sh:36(scans removed diff lines, so it blocks the commit that deletes a secret); feedback-loop tags have no single canonical home;demo/data self-contradicts (Thornbury/Cascadia both pre-sale and signed); CHANGELOG vs settings effort mismatch; Stop-hook nudge likely invisible; undocumentedsecurity-guidanceplugin +autoMemoryEnabled: truedefault..gitignore/examples/SECURITY path correct.See the report for the full list and the 5 quick wins.
Test plan
ops/data as fictional before the next public eyes (highest-value, 1 line/file)pre-commit-guard.shremoved-line bughttps://claude.ai/code/session_01Fnr5bhunxFt116zU1yM1eC
Generated by Claude Code