fix: make LSP signature help integration test reliable#318
Open
eugenioenko wants to merge 1 commit into
Open
Conversation
The signature help test was flaky (~30% failure rate) because the
typescript-language-server occasionally returns null when it hasn't
finished indexing. Added a retry loop that types '(', checks for the
response, and retries up to 3 times. Also increased waitStable delays
for Go to Line dialog initialization in the completion tests.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018GG9dYw2AG18ro5c2dkPtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(, waits 5s for LSP response, backspaces and retries if the server returns nullwaitStabledelays afterctrl+g(Go to Line) from 100ms to 1000ms in the completion testsTest plan
🤖 Generated with Claude Code
https://claude.ai/code/session_018GG9dYw2AG18ro5c2dkPtm