Refactor ep upload to use Fireworks SDK + Auto-generate flags
#379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eworks-sdk-auto-generate-flags # Conflicts: # development/CONTRIBUTING.md # docs/cli_reference/cli_overview.mdx # eval_protocol/auth.py # eval_protocol/cli_commands/utils.py # tests/test_auth.py
dphuang2
changed the title
ep upload to use Fireworks SDK + Auto-generate flags
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…eworks-sdk-auto-generate-flags
…eworks-sdk-auto-generate-flags
…les and remove API_KEY filtering logic
| secrets[key] = value | ||
|
|
||
| return secrets | ||
| return env_vars |
There was a problem hiding this comment.
All env vars now uploaded as secrets, not just API keys
The _load_secrets_from_env_file function previously filtered env vars to only include those with "API_KEY" in the name. This filtering logic was removed, so now ALL environment variables from the .env file are uploaded as Fireworks secrets. This could expose unintended data like DEBUG=true, LOG_LEVEL=info, database URLs, or other non-secret configuration. Additionally, the user-facing message at line 215 still says "API keys" which is now misleading since all env vars are uploaded.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Modernizes evaluator and CLI flows around the Fireworks SDK and trims deprecated commands.
Evaluatorto SDK-basedcreate+get_upload_endpoint+validate_uploadand tarball upload honoring ignore filesdeploy,deploy-mcp,preview,run); keepslogs,upload,create rft,local-test,export-docsupload: auto-generates flags fromFireworks().evaluators.create(); adds aliases/help overrides; reads all.envvars for secrets; supports--force--serverto setFIREWORKS_API_BASE; logging/setup streamlinedplatform_apisecret operations to use SDK types and methodsfireworks-ai==1.0.0a20; removes tests tied to deleted commands and adjusts CLI arg testsWritten by Cursor Bugbot for commit 1d7d807. This will update automatically on new commits. Configure here.