-
Notifications
You must be signed in to change notification settings - Fork 10
enforce single evaluator upload per command #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -334,7 +334,11 @@ def _prompt_select_fallback(tests: list[DiscoveredTest]) -> list[DiscoveredTest] | |
| def _prompt_select(tests: list[DiscoveredTest], non_interactive: bool) -> list[DiscoveredTest]: | ||
| """Prompt user to select tests to upload.""" | ||
| if non_interactive: | ||
| return tests | ||
| # In non-interactive mode, auto-select only the first test | ||
| if len(tests) > 1: | ||
| print(f"Note: {len(tests)} tests discovered. Auto-selecting first test in non-interactive mode:") | ||
| print(f" {_format_test_choice(tests[0], 1)}") | ||
| return [tests[0]] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Empty list access causes crash in non-interactive modeThe |
||
|
|
||
| return _prompt_select_interactive(tests) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
_prompt_selectnon-interactive mode now always returns[tests[0]], so_discover_and_select_testsno longer surfaces when multiple evaluation tests are discovered.create_rft._resolve_evaluator(eval_protocol/cli_commands/create_rft.py:319-341) depends onlen(selected_tests) != 1to force disambiguation; with this changeep create rft --yesin a repo containing multiple tests will silently choose whichever test_discover_testsreturns first and proceed to create datasets/jobs for it instead of erroring, risking creating resources for the wrong evaluator.Useful? React with 👍 / 👎.