-
Notifications
You must be signed in to change notification settings - Fork 10
Implement Evaluator Versions #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dphuang2
wants to merge
33
commits into
main
Choose a base branch
from
dhuang/dxe-478-implement-evaluator-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0a00bcd
Refactor Fireworks client integration
dphuang2 d465a89
remove launch.json
dphuang2 348bb58
Add .vscode/launch.json to .gitignore
dphuang2 acaa901
Enhance environment variable loading in auth module
dphuang2 4b71ddb
Add evaluator version creation in evaluation module
dphuang2 3dbcd59
test
dphuang2 532e071
REVERT this later
dphuang2 5e7a5fa
Merge branch 'main' into dhuang/dxe-478-implement-evaluator-versions
dphuang2 060d72c
fix mock tests
dphuang2 bc31c9f
Add error handling for evaluator creation in evaluation module
dphuang2 ea08062
Support EP_REMOTE_API_KEY
dphuang2 f246087
Merge branch 'main' into dhuang/dxe-478-implement-evaluator-versions
dphuang2 6b53ac1
include launch.json.backup
dphuang2 ec0c8ca
rename to .example and add docker run extra arg
dphuang2 fc036f5
use ignore-docker by default
dphuang2 4566584
delete backup
dphuang2 f103b69
ignore-docker by default in dev
dphuang2 9c3e417
Refactor evaluator function calls to use Fireworks directly for metho…
dphuang2 ea673f4
use in-flight SDK version
dphuang2 26fbc2d
Enhance evaluator handling by returning version ID on creation and up…
dphuang2 4702307
update
dphuang2 9d1bc74
use published a22 of fireworks-ai
dphuang2 3314bec
uv lock
dphuang2 66f191a
Refactor dotenv handling in auth module and integrate environment var…
dphuang2 165afe1
add create rft launch configuration
dphuang2 838c7a5
Refactor dotenv handling in auth module and integrate environment var…
dphuang2 71599e6
Merge branch 'pass-dot-env-to-docker-container' into dhuang/dxe-478-i…
dphuang2 0144c9f
actually not necessary for local test since local-test mounts the wor…
dphuang2 c8774a6
increase sql retries
dphuang2 2076f0a
Refactor dotenv loading to use explicit paths in CLI and API modules
dphuang2 8acdc35
Merge branch 'main' into dhuang/dxe-478-implement-evaluator-versions
dphuang2 432a649
Refactor dotenv loading to use explicit paths in CLI and API modules
dphuang2 ab04086
Merge branch 'ensure-explicit-dotenv' into dhuang/dxe-478-implement-e…
dphuang2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -243,3 +243,5 @@ package.json | |
| tau2-bench | ||
| *.err | ||
| eval-protocol | ||
|
|
||
| .vscode/launch.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| !launch.json.backup |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "EP: Upload", | ||
| "type": "python", | ||
| "request": "launch", | ||
| "module": "eval_protocol.cli", | ||
| "args": ["upload"], | ||
| "console": "integratedTerminal", | ||
| "justMyCode": false, | ||
| "cwd": "<REPLACE_WITH_YOUR_EVALUATOR_DIRECTORY>", | ||
| "env": { | ||
| "PYTHONPATH": "${workspaceFolder}", | ||
| "FIREWORKS_API_KEY": "${env:FIREWORKS_API_KEY}", | ||
| "FIREWORKS_BASE_URL": "${env:FIREWORKS_BASE_URL}", | ||
| "FIREWORKS_EXTRA_HEADERS": "{\"x-api-key\": \"${env:FIREWORKS_API_KEY}\", \"X-Fireworks-Gateway-Secret\": \"${env:FIREWORKS_GATEWAY_SECRET}\"}" | ||
| } | ||
| }, | ||
| { | ||
| "name": "EP: Local Test", | ||
| "type": "python", | ||
| "request": "launch", | ||
| "module": "eval_protocol.cli", | ||
| "args": ["local-test", "--ignore-docker"], | ||
| "console": "integratedTerminal", | ||
| "justMyCode": false, | ||
| "cwd": "<REPLACE_WITH_YOUR_EVALUATOR_DIRECTORY>", | ||
| "env": { | ||
| "PYTHONPATH": "${workspaceFolder}", | ||
| "FIREWORKS_API_KEY": "${env:FIREWORKS_API_KEY}", | ||
| "FIREWORKS_BASE_URL": "${env:FIREWORKS_BASE_URL}", | ||
| "FIREWORKS_EXTRA_HEADERS": "{\"x-api-key\": \"${env:FIREWORKS_API_KEY}\", \"X-Fireworks-Gateway-Secret\": \"${env:FIREWORKS_GATEWAY_SECRET}\"}" | ||
| } | ||
| }, | ||
| { | ||
| "name": "EP: Create RFT", | ||
| "type": "python", | ||
| "request": "launch", | ||
| "module": "eval_protocol.cli", | ||
| "args": [ | ||
| "create", | ||
| "rft", | ||
| "--base-model", | ||
| "accounts/fireworks/models/qwen3-0p6b", | ||
| "--chunk-size", | ||
| "10" | ||
| ], | ||
| "console": "integratedTerminal", | ||
| "justMyCode": false, | ||
| "cwd": "<REPLACE_WITH_YOUR_EVALUATOR_DIRECTORY>", | ||
| "env": { | ||
| "PYTHONPATH": "${workspaceFolder}", | ||
| "FIREWORKS_API_KEY": "${env:FIREWORKS_API_KEY}", | ||
| "FIREWORKS_BASE_URL": "${env:FIREWORKS_BASE_URL}", | ||
| "FIREWORKS_EXTRA_HEADERS": "{\"x-api-key\": \"${env:FIREWORKS_API_KEY}\", \"X-Fireworks-Gateway-Secret\": \"${env:FIREWORKS_GATEWAY_SECRET}\"}" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification endpoint defaults to dev for custom API bases
Medium Severity
The
verify_api_key_and_get_account_idfunction now falls back tohttps://dev.api.fireworks.aifor the verification call when the API base URL doesn't contain "api.fireworks.ai". This causes authentication failures for users with custom endpoints (proxies, internal deployments) who have production API keys, since the verification request goes to dev which rejects production credentials. The fallback should likely use production (https://api.fireworks.ai) instead of dev, or the user's configured base URL should be respected.