Skip to content

fix: include dependency metadata in F-Droid Android APK builds#203

Closed
naltatis wants to merge 1 commit into
mainfrom
test/fdroid-metadata-bug
Closed

fix: include dependency metadata in F-Droid Android APK builds#203
naltatis wants to merge 1 commit into
mainfrom
test/fdroid-metadata-bug

Conversation

@naltatis

Copy link
Copy Markdown
Member

Adjusts the F-Droid Expo config plugin so the Android APK keeps its dependenciesInfo metadata.

  • Sets includeInApk = true in the dependenciesInfo block injected into app/build.gradle
  • Affects the F-Droid / Android release build only

Set includeInApk on the dependenciesInfo block so the Android APK
keeps its dependency metadata.
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

In scripts/fdroid/src/disableDependencyMetadata.ts, the Gradle snippet injected by the withNDKBuildId plugin changes one boolean: includeInApk inside the dependenciesInfo block is now set to true instead of false. The surrounding plugin logic — string replacement on gradleConfig.modResults.contents and returning the modified config — is unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: enabling dependency metadata inclusion in F-Droid Android APK builds by setting includeInApk to true.
Description check ✅ Passed The description clearly explains the change and its purpose: adjusting the F-Droid plugin to include dependency metadata in Android APKs by setting includeInApk = true.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/fdroid/src/disableDependencyMetadata.ts (1)

5-5: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update stale messaging to match includeInApk = true.

Line 5 and Lines 13-15 now contradict the actual behavior at Line 14 (includeInApk = true), which can mislead future debugging and maintenance.

Proposed patch
-    console.log("» F-Droid config plugin: Removing dependency metadata from build.gradle");
+    console.log("» F-Droid config plugin: Enabling dependency metadata in APK build.gradle config");
...
-        // Disables dependency metadata when building APKs.
+        // Enables dependency metadata when building APKs.
         includeInApk = true
         // Disables dependency metadata when building Android App Bundles.
         includeInBundle = false

Also applies to: 13-16

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/fdroid/src/disableDependencyMetadata.ts` at line 5, The console.log
message at line 5 states "Removing dependency metadata from build.gradle", but
this contradicts the actual behavior in the code where includeInApk = true is
set (line 14), which means dependencies are being included, not removed. Update
the console.log message to accurately reflect what the code actually does, and
similarly update any related messaging at lines 13-16 to ensure all log messages
and comments truthfully represent the behavior of setting includeInApk = true.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@scripts/fdroid/src/disableDependencyMetadata.ts`:
- Line 5: The console.log message at line 5 states "Removing dependency metadata
from build.gradle", but this contradicts the actual behavior in the code where
includeInApk = true is set (line 14), which means dependencies are being
included, not removed. Update the console.log message to accurately reflect what
the code actually does, and similarly update any related messaging at lines
13-16 to ensure all log messages and comments truthfully represent the behavior
of setting includeInApk = true.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a6122c8-9dc5-4b0e-b043-85697ff43bfe

📥 Commits

Reviewing files that changed from the base of the PR and between cdab8db and a292220.

📒 Files selected for processing (1)
  • scripts/fdroid/src/disableDependencyMetadata.ts

@naltatis

Copy link
Copy Markdown
Member Author

closing, just a dummy PR for testing the rabbit.

@naltatis naltatis closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant