fix: include dependency metadata in F-Droid Android APK builds#203
fix: include dependency metadata in F-Droid Android APK builds#203naltatis wants to merge 1 commit into
Conversation
Set includeInApk on the dependenciesInfo block so the Android APK keeps its dependency metadata.
WalkthroughIn Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/fdroid/src/disableDependencyMetadata.ts (1)
5-5:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate stale messaging to match
includeInApk = true.Line 5 and Lines 13-15 now contradict the actual behavior at Line 14 (
includeInApk = true), which can mislead future debugging and maintenance.Proposed patch
- console.log("» F-Droid config plugin: Removing dependency metadata from build.gradle"); + console.log("» F-Droid config plugin: Enabling dependency metadata in APK build.gradle config"); ... - // Disables dependency metadata when building APKs. + // Enables dependency metadata when building APKs. includeInApk = true // Disables dependency metadata when building Android App Bundles. includeInBundle = falseAlso applies to: 13-16
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/fdroid/src/disableDependencyMetadata.ts` at line 5, The console.log message at line 5 states "Removing dependency metadata from build.gradle", but this contradicts the actual behavior in the code where includeInApk = true is set (line 14), which means dependencies are being included, not removed. Update the console.log message to accurately reflect what the code actually does, and similarly update any related messaging at lines 13-16 to ensure all log messages and comments truthfully represent the behavior of setting includeInApk = true.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@scripts/fdroid/src/disableDependencyMetadata.ts`:
- Line 5: The console.log message at line 5 states "Removing dependency metadata
from build.gradle", but this contradicts the actual behavior in the code where
includeInApk = true is set (line 14), which means dependencies are being
included, not removed. Update the console.log message to accurately reflect what
the code actually does, and similarly update any related messaging at lines
13-16 to ensure all log messages and comments truthfully represent the behavior
of setting includeInApk = true.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 2a6122c8-9dc5-4b0e-b043-85697ff43bfe
📒 Files selected for processing (1)
scripts/fdroid/src/disableDependencyMetadata.ts
|
closing, just a dummy PR for testing the rabbit. |
Adjusts the F-Droid Expo config plugin so the Android APK keeps its
dependenciesInfometadata.includeInApk = truein thedependenciesInfoblock injected intoapp/build.gradle