EEBus: apply §14a/LPC dimming to OHPCF heat pump

[andig]

The OHPCF heat pump charger (#30636) ignored an active EnWG §14a / LPC consumption limit: it only honoured PV surplus, never the grid-side cap evcc receives as a controllable system.

This implements api.Dimmer on the OHPCF charger, the same hook the loadpoint already uses to push the HEMS dim state down to a charger:

• Dim(true) pauses (or aborts, if the compressor is not pausable) the optional consumption; Dim(false) releases it and resumes per the on/off intent.
• Dimmed() reports the current dim state.
• The control gate now drives the compressor on only when enabled and not dimmed (controlEnable), so a dim always wins over surplus.
• The template gains the dim capability.

go build, go vet, charger + template tests, gofmt and golangci-lint all pass.

🤖 Generated with Claude Code

[sourcery-ai]

Hey - I've left some high level feedback:

• In TestOHPCFDimGate, consider avoiding direct mutation of internal fields like c.dimmed and instead exercise the public API (e.g. Dim) or a small helper constructor to keep tests resilient to internal refactors.
• In Dim, you could early-return when the requested dim state matches the current c.dimmed value to avoid unnecessary apply() calls and external interactions when there is no effective state change.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `TestOHPCFDimGate`, consider avoiding direct mutation of internal fields like `c.dimmed` and instead exercise the public API (e.g. `Dim`) or a small helper constructor to keep tests resilient to internal refactors.
- In `Dim`, you could early-return when the requested `dim` state matches the current `c.dimmed` value to avoid unnecessary `apply()` calls and external interactions when there is no effective state change.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[andig]

Superseded by #31348: dimming now uses the EG LPC consumption limit (like the EEBus meter) instead of OHPCF schedule/pause, and is based on feat/eebus so it can also add the dim capability to the wolfvaillant template.

🤖 Generated with Claude Code