feat(mcp): add/remove rank tracking keywords - #144
Open
Alexi5000 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
web-site-profile
pushed a commit
to web-site-profile/open-seo
that referenced
this pull request
Jul 23, 2026
sorcerai
suggested changes
Jul 28, 2026
sorcerai
left a comment
There was a problem hiding this comment.
Blocking correctness issue: remove_keywords returns removed=args.keywordIds.length, but the repository silently ignores stale/foreign IDs and duplicate IDs can overcount. The MCP response can therefore claim deletions that did not happen. Please return the actual affected-row count or reject/report non-owned IDs, and cover stale, foreign, and duplicate inputs. Project authorization and no-provider-call ordering otherwise look sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #125
Problem
Agents can read rank trackers via
get_rank_tracker, but cannot add or remove tracked keywords without leaving MCP for the dashboard.Fix
add_rank_tracking_keywords→RankTrackingService.addKeywords, with a schedule-aware projected check cost (queued vs live) after the addremove_rank_tracking_keywords→RankTrackingService.removeKeywordsbytrackingKeywordIdtriggerCheck/ metrics refresh (avoids silent credit spend)triggerCheckVerification
pnpm exec prettier --writeon touched MCP filespnpm exec vitest run src/server/mcp/tools/rank-tracking-write-tools.test.tspnpm exec tsc --noEmitpnpm exec oxlinton touched files (--type-aware)Made with Cursor