fix(audit): stop re-billing Lighthouse on workflow and parse retries - #170
Open
Ayush7614 wants to merge 1 commit into
Open
fix(audit): stop re-billing Lighthouse on workflow and parse retries#170Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
Metered lighthouse batches used default Workflow retries and treated post-charge parse failures as plain errors, so a mid-step failure or malformed payload could call DataForSEO again and skip Autumn metering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertOkLighthouse parse failures threw plainError, so Autumn metering skipped the spend and in-process retries called DataForSEO again.How to review
siteAuditWorkflowPhases.ts—LIGHTHOUSE_BATCH_STEP_CONFIGwithretries.limit: 0dataforseo/lighthouse.ts— billing built before parse; parse failures becomeDataforseoChargedTaskErroraudit/lighthouse.ts— break the 3-attempt loop on charged errorsTest plan
pnpm exec vitest run src/server/lib/dataforseo/lighthouse.test.ts src/server/lib/audit/lighthouse.test.ts