chore: prep execution/evm v1.1.0#3392
Conversation
Drop the local replace directives and pin the published upstreams: ev-node v1.2.1 and core v1.1.0. This is the release-ready go.mod for tagging execution/evm/v1.1.0 (new minor: reth 2.3 / Amsterdam fork prep landed here since v1.0.1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
📝 WalkthroughWalkthroughUpdated Changesev-node dependency alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/evm/go.mod`:
- Line 13: Remove the local replace directive for github.com/evstack/ev-node
from apps/evm/go.mod so the dependency version v1.2.1 resolves from the
published module during release validation. Preserve the existing require entry
and do not alter unrelated module directives.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 817499e5-f16e-4387-b790-1ff34899b3ff
⛔ Files ignored due to path filters (1)
execution/evm/go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
apps/evm/go.modexecution/evm/go.modexecution/evm/test/go.modtest/e2e/go.mod
| require ( | ||
| github.com/ethereum/go-ethereum v1.17.4 | ||
| github.com/evstack/ev-node v1.1.3 | ||
| github.com/evstack/ev-node v1.2.1 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
root="$(git rev-parse --show-toplevel)"
cd "$root/apps/evm"
go list -m -f '{{.Path}} {{.Version}} {{.Dir}}' github.com/evstack/ev-node
if go list -m -f '{{.Dir}}' github.com/evstack/ev-node | grep -Fq "$root"; then
echo "ev-node is resolving from the local checkout, not the published module" >&2
exit 1
fiRepository: evstack/ev-node
Length of output: 277
Remove the local replace for release validation
apps/evm/go.mod:6 still rewrites github.com/evstack/ev-node to ../../, so this module resolves the local checkout instead of the published v1.2.1 on line 13. If this bump is meant to exercise the released dependency, gate or remove the replace first.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/evm/go.mod` at line 13, Remove the local replace directive for
github.com/evstack/ev-node from apps/evm/go.mod so the dependency version v1.2.1
resolves from the published module during release validation. Preserve the
existing require entry and do not alter unrelated module directives.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3392 +/- ##
==========================================
- Coverage 62.33% 62.32% -0.01%
==========================================
Files 120 120
Lines 13454 13454
==========================================
- Hits 8386 8385 -1
- Misses 4126 4128 +2
+ Partials 942 941 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Release-ready go.mod for tagging execution/evm/v1.1.0.
Changes
replaceblock (ev-node => ../../,core => ../../core) — local cross-module dev is handled bygo.work(go.work.examplecovers all modules).ev-node v1.1.2 → v1.2.1,core v1.1.0(already required).go.sumgains the v1.2.1 + core v1.1.0 checksums.Why v1.1.0 (new minor)
Last tag was
execution/evm/v1.0.1. Since then reth 2.3 + Amsterdam fork prep (#3352) landed here — new features warrant a minor bump.Verification
go build ./...passes resolving the real published ev-node v1.2.1 + core v1.1.0 (not local replace)go mod tidyis idempotentPart of the v1.2.1 release chain (core/v1.1.0 → v1.2.1 → execution/evm/v1.1.0 → apps/*/v1.2.1).
🤖 Generated with Claude Code
Summary by CodeRabbit