Fix matching on Int[N] and UInt[N] in match statements.#769
Merged
arshajii merged 1 commit intoexaloop:developfrom Mar 24, 2026
Merged
Fix matching on Int[N] and UInt[N] in match statements.#769arshajii merged 1 commit intoexaloop:developfrom
arshajii merged 1 commit intoexaloop:developfrom
Conversation
Contributor
|
Thanks for this PR, @ghuls. Could you please add a test for this? For convenience, I've written one below; you can paste this at the end of @test
def test_int_match():
n = 0
match 42:
case 0:
n = 1
case 42:
n = 2
case 100:
n = 3
case _:
n = 4
assert n == 2
n = 0
match u32(42):
case u32(0):
n = 1
case u32(42):
n = 2
case u32(100):
n = 3
case _:
n = 4
assert n == 2
n = 0
match u32(99):
case u32(0):
n = 1
case u32(42):
n = 2
case u32(100):
n = 3
case _:
n = 4
assert n == 4
n = 0
match i32(42):
case i32(0):
n = 1
case i32(42):
n = 2
case i32(100):
n = 3
case _:
n = 4
assert n == 2
n = 0
match i32(99):
case i32(0):
n = 1
case i32(42):
n = 2
case i32(100):
n = 3
case _:
n = 4
assert n == 4
test_int_match() |
30cd2c9 to
66332f0
Compare
Contributor
Author
|
@arshajii Added. |
Contributor
|
Awesome, thanks! Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #754