-
Notifications
You must be signed in to change notification settings - Fork 172
Team E2563 - Review Tableau API #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Prismly
wants to merge
15
commits into
expertiza:main
Choose a base branch
from
YUMO9743:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows the review tableau to display scores (previously no scores were retrieved, to be looked into)
- Added a new API endpoint, get_review_tableau_data, which retrieves the specific answers and comments made by a given reviewer across all reviews they filled out for a given assignment.
- get_review_tableau_data now additionally returns participant and assignment information, past just ids. Notably, this is used to display the username of the student on the review tableau page
- Question type strings are now reported on a per-Item basis.
This reverts commit 636a897.
Generated by 🚫 Danger |
- This is to account for responses sharing a mapping id (in case they do that)
Added a string conversion for an integer being used for an sql query.
- get_review_tableau_data now has support for varying min/max answer scores (for different scales)
Add rspec test cases for the new review tablaeu endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to complete the following user story:
For this purpose, the grades_controller.rb controller has been expanded to include a new GET endpoint, called get_review_tableau_data. Please see the E2563 wiki page for a more detailed writeup of the implementation in this PR, from both back end and front end perspectives.
Please also see the corresponding front end pull request for the accompanying front end view required to see the output of the endpoint displayed.