Skip to content

chore: publish with provenance #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vonovak wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −4
Open

chore: publish with provenance #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,22 @@
# adapted from https://github.com/googleapis/release-please-action#automating-publication-to-npm
name: release-please

on:
push:
branches:
- main
name: release-please
env:
# renovate datasource=github-releases depName=jdx/mise
MISE_VERSION: 'v2025.11.7'

# `id-token` for publishing: https://docs.npmjs.com/trusted-publishers#github-actions-configuration
# the rest for release-please: https://github.com/googleapis/release-please-action#basic-configuration
permissions:
id-token: write # Required for kOIDC
contents: write # Required by release-please to create a release
pull-requests: write # Required by release-please to open a release PR
issues: write # Required by release-please to comment on release-related issues

jobs:
release-please:
runs-on: ubuntu-latest
Expand All @@ -31,7 +41,6 @@ jobs:
if: ${{ steps.release.outputs.release_created }}
- run: yarn --immutable
if: ${{ steps.release.outputs.release_created }}
- run: npm publish
Copy link
Member

@nicknovitski nicknovitski Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want to use yarn npm publish? I know it has a --provenance flag.

Copy link
Contributor Author

@vonovak vonovak Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only npm supports trusted publishing via GH actions I think, unless yarn has caught up.

Copy link
Member

@nicknovitski nicknovitski Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know when they added it, but it does seem to work: https://github.com/expo/expo-server-sdk-node/actions/runs/19714540423/job/56483394190?pr=239#step:7:30

env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
- run: |
yarn npm publish --provenance
if: ${{ steps.release.outputs.release_created }}