Skip to content

wolfssl-sys: Bring back optimisations for X86_64 macOS catalyst app#313

Merged
kp-thomas-yau merged 2 commits into
mainfrom
catalyst-build-flag
Nov 19, 2025
Merged

wolfssl-sys: Bring back optimisations for X86_64 macOS catalyst app#313
kp-thomas-yau merged 2 commits into
mainfrom
catalyst-build-flag

Conversation

@kp-thomas-yau
Copy link
Copy Markdown
Contributor

Same as expressvpn/lightway-core#210

Forgot to add back optimisations for macOS catalyst x86_64, so add it back in to improve speed and efficiency.

…ptimisations

Mac catalyst now lacks hardware optimisations build flags, so we update it to only exclude iOS x86_64 simulator.
Read target environment from build_target instead for uniformity.
@github-actions
Copy link
Copy Markdown

Code coverage summary for 697450c:

Filename                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
wolfssl-sys/src/lib.rs                    25                 0   100.00%           2                 0   100.00%          13                 0   100.00%           0                 0         -
wolfssl/src/aes256.rs                    166                 8    95.18%          11                 0   100.00%         124                 4    96.77%           0                 0         -
wolfssl/src/chacha20_poly1305.rs          75                 2    97.33%           5                 0   100.00%          66                 2    96.97%           0                 0         -
wolfssl/src/context.rs                   401               173    56.86%          41                14    65.85%         286               110    61.54%           0                 0         -
wolfssl/src/error.rs                      45                13    71.11%           5                 1    80.00%          44                11    75.00%           0                 0         -
wolfssl/src/lib.rs                        81                15    81.48%          11                 1    90.91%          72                13    81.94%           0                 0         -
wolfssl/src/rng.rs                        72                10    86.11%           6                 0   100.00%          42                 3    92.86%           0                 0         -
wolfssl/src/ssl.rs                      1240               375    69.76%          77                25    67.53%         803               249    68.99%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                   2105               596    71.69%         158                41    74.05%        1450               392    72.97%           0                 0         -

✅ Region coverage 71% passes
✅ Line coverage 72% passes

@kp-thomas-yau kp-thomas-yau marked this pull request as ready for review November 18, 2025 12:57
@kp-thomas-yau kp-thomas-yau requested a review from a team as a code owner November 18, 2025 12:57
@kp-thomas-yau kp-thomas-yau merged commit 16625ae into main Nov 19, 2025
20 checks passed
@kp-thomas-yau kp-thomas-yau deleted the catalyst-build-flag branch November 19, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants