WIP : Jump to animation keyframe #2589
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ni-g-3l
changed the title
mwestphal
reviewed
Dec 5, 2025
Comment on lines
+269
to
+270
| this->Importer->GetTemporalInformation( | ||
| currentAnimation, 1 / this->DeltaTime, nbTimeSteps, this->TimeRange, timeSteps); |
Member
There was a problem hiding this comment.
imo timesteps should only checked once, when we recover the time range
Contributor
Author
There was a problem hiding this comment.
TimeSteps are computed on the first call to jump_key_frame then store into AnimationTimeStep optional.
If we add some print like this :
Here is the result :
Member
There was a problem hiding this comment.
Yeah I see that, but why not recovering them in PrepareForAnimationIndices ?
mwestphal
reviewed
Dec 5, 2025
mwestphal
requested changes
Dec 5, 2025
testing/recordings/TestInteractionAnimationKeyFrameByKeyFrame.log
Outdated
Show resolved
Hide resolved
|
You are modifying libf3d public API! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR allows user to play animation frame by frame
frame_by_frame_anim.mp4
However, it is based on GetTemporalInformation from vtkImporter, so It will works only for native VTK Importer for now.
Attach here a GLTF file with an animation if you want to test.
AnimatedCube.zip
Issue ticket number and link if any
#2559
#2682
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.