Skip to content

Conversation

@mgarrard
Copy link
Contributor

@mgarrard mgarrard commented Nov 7, 2025

Differential Revision: D86492676

Dark Knight added 2 commits November 6, 2025 21:50
Summary:

This diff reverts D86267649
There are issues loading and generating candidates for GS after the node name changes, unland to unblock exps in Ax

Depends on D86267649

Differential Revision: D86492664
Differential Revision: D86492676
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 7, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 7, 2025

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86492676.

mgarrard pushed a commit to mgarrard/Ax that referenced this pull request Nov 7, 2025
Summary: Pull Request resolved: facebook#4515

Differential Revision: D86492676
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.56%. Comparing base (bf2252d) to head (770530a).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
ax/generation_strategy/generation_strategy.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4515      +/-   ##
==========================================
- Coverage   96.57%   96.56%   -0.01%     
==========================================
  Files         546      546              
  Lines       56045    56062      +17     
==========================================
+ Hits        54124    54139      +15     
- Misses       1921     1923       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants