Add TorchAdapter validation to TopSurfacesAnalysis #4526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TopSurfacesAnalysis requires a TorchAdapter to function correctly. This change adds validation in the validate_inputs method to ensure that a TorchAdapter is available before the analysis runs, providing a clearer error message if not.
Essentially an extension of D84641586
Without this, the top surfaces analysis fails with a much more opaque error (came up while investigating T244217568):
Differential Revision: D86793014