Subsetting of trial indices with MapData #4712
Open
+65
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Dec 26, 2025
Summary: **Issue:** Explanatory notebook by me & mate: N8907563 In practice: N8887885 Previously, when using Experiment.clone_with() in Ax to clone a subset of trials, the cloned trials were assigned new auto-incremented indices (e.g., 0, 1, 2...) rather than preserving their original indices from the source experiment. This led to downstream issues in extraction methods (_extract_arm_data / _extract_observation_data) which rely on trial indices being consistent between the experiment and its associated data. As a result, extracted arm and observation data would be incomplete. **Fix:** Modified both Trial.clone_to() and BatchTrial.clone_to() so that when cloning to a different experiment, the original trial index is preserved (index=self.index). When cloning to the same experiment, a new index is auto-assigned to avoid index collision (maintaining previous behavior for this use case). Differential Revision: D89661997 Privacy Context Container: L1307644
hvarfner
force-pushed
the
export-D89661997
branch
from
fdbb8a2 to
4610b74
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Dec 26, 2025
Summary: **Issue:** Explanatory notebook by me & mate: N8907563 In practice: N8887885 Previously, when using Experiment.clone_with() in Ax to clone a subset of trials, the cloned trials were assigned new auto-incremented indices (e.g., 0, 1, 2...) rather than preserving their original indices from the source experiment. This led to downstream issues in extraction methods (_extract_arm_data / _extract_observation_data) which rely on trial indices being consistent between the experiment and its associated data. As a result, extracted arm and observation data would be incomplete. **Fix:** Modified both Trial.clone_to() and BatchTrial.clone_to() so that when cloning to a different experiment, the original trial index is preserved (index=self.index). When cloning to the same experiment, a new index is auto-assigned to avoid index collision (maintaining previous behavior for this use case). Differential Revision: D89661997 Privacy Context Container: L1307644
Summary: **Issue:** Explanatory notebook by me & mate: N8907563 In practice: N8887885 Previously, when using Experiment.clone_with() in Ax to clone a subset of trials, the cloned trials were assigned new auto-incremented indices (e.g., 0, 1, 2...) rather than preserving their original indices from the source experiment. This led to downstream issues in extraction methods (_extract_arm_data / _extract_observation_data) which rely on trial indices being consistent between the experiment and its associated data. As a result, extracted arm and observation data would be incomplete. **Fix:** Modified both Trial.clone_to() and BatchTrial.clone_to() so that when cloning to a different experiment, the original trial index is preserved (index=self.index). When cloning to the same experiment, a new index is auto-assigned to avoid index collision (maintaining previous behavior for this use case). Differential Revision: D89661997 Privacy Context Container: L1307644
hvarfner
force-pushed
the
export-D89661997
branch
from
4610b74 to
e5a99a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4712 +/- ##
==========================================
- Coverage 96.69% 96.69% -0.01%
==========================================
Files 580 580
Lines 60714 60731 +17
==========================================
+ Hits 58708 58723 +15
- Misses 2006 2008 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue:
N8887885
Previously, when using Experiment.clone_with() in Ax to clone a subset of trials, the cloned trials were assigned new auto-incremented indices (e.g., 0, 1, 2...) rather than preserving their original indices from the source experiment. This led to downstream issues in extraction methods (_extract_arm_data / _extract_observation_data) which rely on trial indices being consistent between the experiment and its associated data. As a result, extracted arm and observation data would be incomplete.
Fix:
Modified both Trial.clone_to() and BatchTrial.clone_to() so that when cloning to a different experiment, the original trial index is preserved (index=self.index).
When cloning to the same experiment, a new index is auto-assigned to avoid index collision (maintaining previous behavior for this use case).
Differential Revision:
D89661997
Privacy Context Container: L1307644