refactor(core): replace evaluate with vm.compileFunction#11685
Open
torresgol10 wants to merge 1 commit intofacebook:mainfrom
Open
refactor(core): replace evaluate with vm.compileFunction#11685torresgol10 wants to merge 1 commit intofacebook:mainfrom
torresgol10 wants to merge 1 commit intofacebook:mainfrom
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
The
evalpackage is currently used to evaluate the server bundle. However, this package is unmaintained and archived.This PR replaces the dependency on
evalwith Node.js nativevm.compileFunction. This reduces external dependencies while strictly maintaining the existing behavior (executing the bundle with access to parent module'srequire).Test Plan
I verified the changes by running the full website build locally, which acts as an end-to-end test for the SSG renderer.
yarn build:websitein the root workspace.builddirectory.Test links
N/A (Local verification only)
Related issues/PRs
N/A